Add option to enable proxy header #8675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
force-pushed
the
8626-add-option-to-enable-proxy-header
branch
2 times, most recently
from
96ca27e to
d6c7e0d
Compare
FirelightFlagboy
force-pushed
the
8626-add-option-to-enable-proxy-header
branch
2 times, most recently
from
7aa594b to
2116aee
Compare
mmmarcos
reviewed
Oct 9, 2024
FirelightFlagboy
force-pushed
the
8626-add-option-to-enable-proxy-header
branch
2 times, most recently
from
d2b22cd to
937fa63
Compare
FirelightFlagboy
force-pushed
the
8626-add-option-to-enable-proxy-header
branch
from
185d6d0 to
b1a93d3
Compare
mmmarcos
reviewed
Oct 9, 2024
Add a new option that configure the list of trusted address to parse the proxy headers from.
The parsing is handled by `uvicorn` which currently only support `x-forwarded-{for,proto}` headers.
Closes #8626, closes #8427
Co-authored-by: Marcos Medrano <[email protected]>
FirelightFlagboy
force-pushed
the
8626-add-option-to-enable-proxy-header
branch
from
91570d6 to
c5299f9
Compare
mmmarcos
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option that configure the list of trusted address to parse the proxy headers from.
The parsing is handled by
uvicornwhich currently only supportx-forwarded-{for,proto}headers.Closes #8626, closes #8427