-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add purpose
field to device certificate
#8855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
force-pushed
the
device-certificate-type-field
branch
from
November 5, 2024 15:16
cf01a96
to
587abf1
Compare
FirelightFlagboy
approved these changes
Nov 5, 2024
Comment on lines
+66
to
+69
{ | ||
"name": "WebAuth", | ||
"discriminant_value": "WEB_AUTH" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫣
AureliaDolo
approved these changes
Nov 5, 2024
touilleMan
force-pushed
the
device-certificate-type-field
branch
from
November 5, 2024 15:50
3a3e21b
to
41f9bae
Compare
Max-7
approved these changes
Nov 5, 2024
touilleMan
force-pushed
the
device-certificate-type-field
branch
from
November 6, 2024 08:58
eaed2b7
to
3b3db49
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 6, 2024
…ces from regular ones)
touilleMan
force-pushed
the
device-certificate-type-field
branch
from
November 6, 2024 15:59
3b3db49
to
3806da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8748
Used to flag recovery devices from regular ones