Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purpose field to device certificate #8855

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

touilleMan
Copy link
Member

close #8748

Used to flag recovery devices from regular ones

@touilleMan touilleMan requested a review from a team as a code owner November 5, 2024 14:25
@touilleMan touilleMan force-pushed the device-certificate-type-field branch from cf01a96 to 587abf1 Compare November 5, 2024 15:16
Comment on lines +66 to +69
{
"name": "WebAuth",
"discriminant_value": "WEB_AUTH"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫣

@vxgmichel vxgmichel requested a review from a team as a code owner November 5, 2024 15:33
@touilleMan touilleMan force-pushed the device-certificate-type-field branch from 3a3e21b to 41f9bae Compare November 5, 2024 15:50
@touilleMan touilleMan requested a review from a team as a code owner November 5, 2024 16:01
@vxgmichel vxgmichel requested a review from a team as a code owner November 5, 2024 16:05
@touilleMan touilleMan force-pushed the device-certificate-type-field branch from eaed2b7 to 3b3db49 Compare November 6, 2024 08:58
@touilleMan touilleMan added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@touilleMan touilleMan force-pushed the device-certificate-type-field branch from 3b3db49 to 3806da5 Compare November 6, 2024 15:59
@touilleMan touilleMan enabled auto-merge November 6, 2024 15:59
@touilleMan touilleMan added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 9be43b4 Nov 6, 2024
16 checks passed
@touilleMan touilleMan deleted the device-certificate-type-field branch November 6, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update device model to include a type field
5 participants