Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github workflow if condition using not operator #9000

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix github workflow if condition using not operator #9000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/package-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ jobs:
# We need to patch the vite.config.js because we cannot pass the secret to the snap build (either via build-args or env).
# Build we only do that is the event is not a PR from dependabot (because it does not have access to secrets, thus failing the build).
- name: Patch vite config for snap build
if: !(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]')
if: (!(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]'))
run: >-
sed -i
-e s'/if (process.env.PARSEC_APP_SENTRY_AUTH_TOKEN)/if (true)/'
Expand All @@ -188,7 +188,7 @@ jobs:

# We only patch snapcraft.yaml is the event is not a PR from dependabot (because it does not have access to secrets, thus failing the build).
- name: Patch snapcraft file for sentry auth token
if: !(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]')
if: (!(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]'))
run: >-
sed -i -e s';SENTRY_AUTH_TOKEN: __TOKEN__;SENTRY_AUTH_TOKEN: "${{ secrets.SENTRY_AUTH_TOKEN }}";' snap/snapcraft.yaml
working-directory: client/electron
Expand Down Expand Up @@ -396,7 +396,7 @@ jobs:

# Do not upload sourcemaps if it's a PR from dependabot because it does not have access to secrets.
- name: Upload client electron sourcemaps
if: !(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]')
if: (!(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]'))
run: npm run sentry:sourcemaps
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
publish:
runs-on: ubuntu-24.04
# We don't want to run this workflow on dependabot PRs because it will not be able to read the secrets
if: !(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]')
if: (!(github.event_name == 'pull_request' && github.actor == 'dependabot[bot]'))
permissions:
contents: read
id-token: write
Expand Down
Loading