Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get-Encoding will fail when charset is incorrect #5764

Closed
wants to merge 1 commit into from
Closed

fix: Get-Encoding will fail when charset is incorrect #5764

wants to merge 1 commit into from

Conversation

ChrisCatCP
Copy link

@ChrisCatCP ChrisCatCP commented Dec 17, 2023 •
edited
Loading

Description

fix: Get-Encoding will fail when charset is incorrect

Motivation and Context

Closes #5763

How Has This Been Tested?

checkver by https://baoku.360.cn/soft/show/appid/1900021484

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@HUMORCE
Copy link
Member

HUMORCE commented Dec 24, 2023

This will fall back all incorrect charsets to UTF-8. For sample page, create checkver.script to handle it separately is enough, and report the issue to the site.

@ChrisCatCP ChrisCatCP closed this Dec 24, 2023
@HUMORCE HUMORCE mentioned this pull request Dec 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisCatCP @HUMORCE