Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: required properties are supplied via a constructor function #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ColinEberhardt
Copy link
Collaborator

@OiNutter based on your suggestions on this PR #50 - this is an alternative implementation where constructors are used for required properties.

The debate about interfaces / classes aside (#51), I do think this is a cleaner way to handle required properties.

@OiNutter
Copy link

OiNutter commented Jun 8, 2023

Great, happy it was a sensible suggestion!

Not that familiar with the code so my approving the request is meaningless but what you're doing looks sensible.

Quick one just from looking at it though, have you considered using .hbs file extensions instead of .handlebars? Didn't know if there'd been a conscious choice to go this way, or if you weren't aware of the .hbs extension? Just thought it might save some typing 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants