Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff & project standardization #5

Merged
merged 19 commits into from
Feb 20, 2024
Merged

Conversation

bandophahita
Copy link
Contributor

@bandophahita bandophahita commented Feb 16, 2024

implementing ruff and project standardization
ScreenPyHQ/screenpy#127

@bandophahita bandophahita marked this pull request as ready for review February 16, 2024 00:04
@bandophahita bandophahita mentioned this pull request Feb 16, 2024
@bandophahita bandophahita self-assigned this Feb 16, 2024
perrygoy
perrygoy previously approved these changes Feb 17, 2024
Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only had one comment about removing setup.py that we might want to consider.

screenpy_pyotp/__version__.py Show resolved Hide resolved
setup.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be deleting setup.py as part of our project standardization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be done in a separate PR.

tests/test_abilities.py Show resolved Hide resolved
@bandophahita bandophahita changed the title Ruff Ruff & project standardization Feb 17, 2024
Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll remove setup.py in a future one.

@bandophahita bandophahita merged commit 796328a into ScreenPyHQ:trunk Feb 20, 2024
11 checks passed
@bandophahita bandophahita deleted the ruff branch February 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants