Skip to content

Commit

Permalink
- Upgrading to Java 17
Browse files Browse the repository at this point in the history
- Minor Update to Doc
- Trying to fix fiddly github actions
  • Loading branch information
Soumendra Daas committed Oct 27, 2023
1 parent 9e4d98d commit 066e994
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 13 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# See https://github.com/actions/starter-workflows/blob/main/ci/maven.yml
# and https://github.com/actions/setup-java
name: Java CI with Maven
on:
push:
Expand All @@ -8,12 +10,12 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up JDK 11
uses: actions/setup-java@v2
- uses: actions/checkout@v3
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'adopt'
java-version: '17'
distribution: 'corretto'
cache: maven
- name: Build with Maven
run: mvn -B package --file pom.xml
5 changes: 0 additions & 5 deletions .travis.yml

This file was deleted.

12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,25 @@ master branch. See [maven.yml](.github/workflows/maven.yml)

### Release process

See the process to [prepare](https://maven.apache.org/maven-release/maven-release-plugin/usage/prepare-release.html)
and [perform](https://maven.apache.org/maven-release/maven-release-plugin/usage/perform-release.html) the
release, but the steps are ...

* Make sure that all files are committed
* `mvn test`
* `mvn release:prepare -DdryRun=true`
* You will be prompted for the release version to use
* `mvn release:clean`
* `mvn release:prepare`
* `mvn release:perform`
* Assuming that we are releasing `A.B.C`
* At this point the pom.xml should have been updated to the `next-version-SNAPSHOT` version
* There should a github tag called `vA.B.C`
* We still need to create a Release (and release notes) manually from this tag.
* Run `git tag`. There should a github tag called `vA.B.C`

* We still need to create a Release (and release notes) manually from this tag.
* Go to `https://github.com/Sdaas/hello-karate/tags`
* Select the latest tag and `Release` it

### References

* [Karate DSL ](https://github.com/karatelabs/karate)
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<description>Getting started with Karate</description>

<properties>
<java.version>11</java.version>
<java.version>17</java.version>

<junit-jupiter.version>5.9.3</junit-jupiter.version>
<karate.version>1.4.1</karate.version>
Expand Down

0 comments on commit 066e994

Please sign in to comment.