Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SQLx to 0.8 #2305

Merged
merged 18 commits into from
Aug 9, 2024
Merged

Bump SQLx to 0.8 #2305

merged 18 commits into from
Aug 9, 2024

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Aug 1, 2024 •
edited
Loading

PR Info

Changes

  • Bump sqlx to 0.8
  • Bump bigdecimal to 0.4

@billy1624 billy1624 self-assigned this Aug 1, 2024
This was referenced Aug 1, 2024
Merged
Merged
@Expurple Expurple mentioned this pull request Aug 4, 2024
Closed
@billy1624 billy1624 requested a review from tyt2y3 August 7, 2024 08:14
@billy1624 billy1624 marked this pull request as ready for review August 7, 2024 08:14
tyt2y3
tyt2y3 reviewed Aug 8, 2024
View reviewed changes
tests/uuid_tests.rs Outdated
"type": metadata.ty,
"key": metadata.key,
"value": 1.18,
"bytes": "\u{1}\u{2}\u{3}",
Copy link
Member

@tyt2y3 tyt2y3 Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else looks good... except this. bytes (Vec<u8>) now becomes a string ?
this is not workable, as the byte content can be invalid utf8

Copy link
Member Author

@billy1624 billy1624 Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the assertions change. And modified the into_json logic instead 6cda01e.

tyt2y3
tyt2y3 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@billy1624 billy1624 merged commit 563562d into master Aug 9, 2024
29 checks passed
@billy1624 billy1624 deleted the sqlx-0.8 branch August 9, 2024 10:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

🎉 Released In 1.1.0-rc.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@github-actions GitHub Actions
Copy link

🎉 Released In 1.1.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support sqlx v0.8
2 participants
@billy1624 @tyt2y3