call EnumIter::get using fully qualified syntax
#2321
Conversation
`itertools` version 0.13.0 added a `get` method that takes precedence over the `EnumIter::get` method. The `EnumIter` derive should be calling the method fully-qualified to ensure that the local version is called rather than the method that is provided by the `Itertools` trait. This was fixed in `strum` 0.26.x, but since this is a forked/adapted version of the `EnumIter` derive, it requires the same fix .
|
Oh, so that's what has been preventing me from updating to |
|
Is there something I am missing or need to do to get a review? |
|
For the last few months, maintainers pay very little attention to community issues/PRs :( It's weird, given that they still release new versions, blog posts, etc. They're probably focusing on their own checklist for |
There was a problem hiding this comment.
Hey @jcreekmore, sorry for the delay! I will merge this today and publish a new RC with this.
🎉 Released In 1.1.0-rc.2 🎉Thank you everyone for the contribution! |
🎉 Released In 1.1.0 🎉Thank you everyone for the contribution! |
Bug Fixes
itertoolsversion 0.13.0 added agetmethod that takes precedence over theEnumIter::getmethod. TheEnumIterderive should be calling the method fully-qualified to ensure that the local version is called rather than the method that is provided by theItertoolstrait. This was fixed instrum0.26.x, but since this is a forked/adapted version of theEnumIterderive, it requires the same fix .