Insert many allow active models to have different column set #2433
+163
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this should have solved the problem once and for all. Since this is changing a core part of the library, we should test it more to prevent regression. The safest way might be to have a new method |
tyt2y3
commented
Dec 2, 2024
src/query/insert.rs
Outdated
Comment on lines
195
to
197
| for col in columns.iter() { | ||
| self.columns.push(col.is_some()); | ||
| } |
There was a problem hiding this comment.
thanks. self.columns is really for use with add(). so should we do self.columns.clear() first?
There was a problem hiding this comment.
Okay, reset (clear) it before altering it seems safer.
There was a problem hiding this comment.
Or simply replace the columns vector, isn't this more readable?
self.columns = columns.iter().map(Option::is_some).collect();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1407
This requires a new feature in sea-query, Value::as_null