Use orthogonal data for DataTables #865
Open
+33
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assigning HTML directly as data, we can use assign an object with the following keys: - display - The display value of the data (same as what we had) - filter - Value used for filtering (e.g. SearchBuilder) - order - Value used for sorting This will make DataTables easier to expand in the long run. Since we can assign different attributes to the data. Also fixes SemanticMediaWiki#831
We don't need it anymore because values are assigned a sorting key
|
Looks good. @thomas-topway-it can you also check this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make DataTables easier to expand and maintain. Now we can assign different attributes to the data, and this will resolve any sorting and filtering issues that we had.
Added
Instead of assigning HTML directly as data, we can assign an object with the following keys:
display- The display value of the data (same as what we had)filter- Value used for filtering (e.g. SearchBuilder)sort- Value used for sortingRemoved
any-number- Not needed anymore because sort key are always sortabledatatables-column.type- Same reason as abovehttps://datatables.net/manual/data/orthogonal-data
Fix #831