Skip to content

Commit

Permalink
fix php 7.4 compatibility problems
Browse files Browse the repository at this point in the history
  • Loading branch information
oetterer committed Jul 23, 2024
1 parent b349c65 commit 379bf06
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ jobs:
strategy:
matrix:
include:
- mw: 'REL1_39'
php: 7.4
type: normal
experimental: false
- mw: 'REL1_39'
php: 8.0
type: coverage
Expand Down
24 changes: 24 additions & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
This file contains the RELEASE-NOTES of the **Semantic Scribunto** (a.k.a. SSC) extension.

## 2.3.2

Released on July 23, 2024

* Fixes PHP 7.3 issue

## 2.3.1

Released on July 16, 2024

* Fixes message registration

## 2.3.0

Released on July 16, 2024

* Raising minimum requirement to MW 1.39 and SMW 4.1
* Switch unit tests from tavis to github
* Add new ci sets for MW > 1.39
* Switch hook registration to default MW schema
* Switch to MW autoloader, abandoning composer autoloader
* Fix unit tests


## 2.2.0

Released on January 19, 2022.
Expand Down
4 changes: 2 additions & 2 deletions src/ScribuntoLuaLibrary.php
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ private function getLibraryFactory(): LibraryFactory {
*
* @return bool
*/
private function isAQueryResult( mixed $queryResult ): bool {
private function isAQueryResult( $queryResult ): bool {
return is_a( $queryResult, QueryResult::class );
}

Expand All @@ -350,7 +350,7 @@ private function isAQueryResult( mixed $queryResult ): bool {
*
* @return array
*/
private function processLuaArguments( mixed $arguments ) {
private function processLuaArguments( $arguments ) {

if ( empty( $arguments ) ) {
return [];
Expand Down

0 comments on commit 379bf06

Please sign in to comment.