-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation fixes and improvements #466
Conversation
9aad1be
to
6e63ba8
Compare
As a convenience, this and most other recent pull-request are available merged in my repository: These changes are also updated to the documentation page available at: |
03db59b
to
1c4400c
Compare
32aa226
to
ea93448
Compare
Using localhost in the url doesn't work, so took me a while to figure out the correct URL.
* links fixed and changed to relative. Absolute links are not supported by mkdocs: https://www.mkdocs.org/user-guide/writing-your-docs/#linking-to-pages
Basically contains most changes from: SensorsIot#338 * Dark and light modes * Always expand left-navigation folders, improving usability
* Only relative links withing pages are supported: https://www.mkdocs.org/user-guide/writing-your-docs/#linking-to-pages As an additional benefit, when running: $ mkdocs serve it will issues a warnings for invalid relative links
* Add top tabs: Basic setup, Containers, Developers * these were chosen in order to be in a sensible alphabetical order * files moved to corresponding folders and links updated * Add redirect from old file locations * "Basic setup" has a lot of items. Update related pages organized into the "Updates" subtopic, to make it a bit more clear.
Remove custom anchor links and generate them automatically using the toc markdown extension. Links updated to match new anchors. This fixes the custom links coloring the heading blue, which isn't the best if user selects the dark theme. Heading changes done by: cd docs && sed -i -r 's/(#*).*> (.*?) <\/a>/\1 \2/g' *md */*md */*/*md
* per default, navigation tabs disappear when you scroll down the page, which may confuse some users * hide "Made with Material" footer which is visible when scrolling to the bottom, which takes up space and may make the left menu scrollbar to appear, and thus reduce usability.
ea93448
to
bb6b23d
Compare
PR SensorsIot#477 uses default network, updating docs to match
Fix script comment to properly describe how th bridge gateway works.
Alphabetical ordering is case sensitive, rename all files to start with a capital letter.
cf101cc
to
4f52cf0
Compare
Hey @ukkopahis sorry this took so long to review. I've approved it now, but it looks like there are now some merge conflicts. I wasn't able to resolve them myself as I can't push to your remote. |
Pull-requests like #489 had changes the same files as this. As such either it or this could be cleanly merged, not both. Don't know why you couldn't push to my branch. I have "allow edits" ticked: |
43bcf72
to
477a064
Compare
# Conflicts: # .github/workflows/main.yml # docs/Containers/Blynk_server.md # docs/Containers/Home-Assistant.md # docs/Containers/Node-RED.md # docs/Containers/Prometheus.md
477a064
to
383d213
Compare
Github lost your already reviewed changed when I tried rebasing. So here's the conflict-resolution as a merge commit, and a couple new commits. |
Summary of additional improvements since the previous review.
Post-merge tasks
|
037f0e7
to
6b50e5f
Compare
includes some changes from SensorsIot#501 Fixes SensorsIot#500 Co-authored-by: ukkopahis <[email protected]>
source: https://primer.style/octicons/stack-24 Licence: MIT License The MIT-licence requires for you to include the copyright notice and the permission notice when using substantial portions of the Software. This one svg-file is not a substantial portion of the project: https://github.com/primer/octicons As such the licence is only noted in full here: MIT License Copyright (c) 2022 GitHub Inc. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Add Discord link to Wiki home page. Only show relevant (wide/narrow) layout navigation advice. Hide Navigation and add project mission statement quote.
* better usability, especially on the narrow layout
6b50e5f
to
9c1263e
Compare
* also works on the 64-bit Raspberry OS * state importance of the pathces in no uncertain terms * rephrase assumptions in a more concise way * extract small essay about sudo into its own "What is sudo?"-page * move "updating from gcgarner"-link to the Home page
9c1263e
to
4d69183
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise this is a bit late but, on reflection, I think that moving the "a word about sudo" material to another file might not be a particularly good idea. Rolling back the clock a bit to something like 18 months ago, it seemed like 2 out of every 3 problems raised on Discord could be traced back to improper use of sudo. That fell right off once those words went into the getting started doco. Granted, I also added code to many scripts saying "don't run this with sudo" and that probably also had an impact. But the "getting started" document is The Key Document referred to in the primary read-me. That really puts the words about sudo "in ya face" for new users. I'm not sure it will have the same mindshare if it is moved. I'm sure I don't need to tell you the kinds of chaos that can be created from improper use of sudo. People with reasonable Linux experience probably wouldn't make the mistake in the first place but, if they did, would probably be able to recognise the problem and undo the damage. Those aren't the people I worry about. I worry about people who just follow gists and web pages, who see a Pi as a means to an end rather than something they want to develop a deep understanding of, and who get horribly stuck if they make a basic mistake like sudo git clone ... IOTstack
and then find nothing works. I'm not saying "put it back". I'm just asking you to keep these comments in mind if there's an uptick in sudo-related problems in issues and on Discord.
I don't think very long "Getting Started" is user friendly.
Good info. I'll monitor for such problems re-occurring, and correct back if needed. I'm still planning to:
|
One pull request to gather improvements and fixes to the documentation.
Fixes:
Improvements:
Changes:
(these were chosen in order to be in a sensible alphabetical order)
Resolves:
New top tabs look like this (live version):
And in dark mode: