Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-04-02 missing port-mapping quotes - master branch - PR 1 of 2 #762

Merged

Conversation

Paraphraser
Copy link

Following on from discussion in #761, this adds quotes to port mappings as recommended in docker-compose
documentation:

HOST:CONTAINER should always be specified as a (quoted) string, to avoid conflicts with yaml base-60 float

Following on from discussion in SensorsIot#761, this adds quotes to port mappings
as recommended in docker-compose
[documentation](https://docs.docker.com/compose/compose-file/05-services/#short-syntax-3):

> HOST:CONTAINER should always be specified as a (quoted) string, to
avoid conflicts with
[yaml base-60 float](https://yaml.org/type/float.html)

Signed-off-by: Phill Kelley <[email protected]>
@Slyke Slyke merged commit c0c4630 into SensorsIot:master Apr 30, 2024
@Paraphraser Paraphraser deleted the 20240402-port-pair-quotes-master branch May 4, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants