Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 330 수정 #323

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Translate 330 수정 #323

merged 3 commits into from
Apr 28, 2021

Conversation

dididy
Copy link
Collaborator

@dididy dididy commented Apr 22, 2021

@dididy dididy added the 📝확인요청 Review 해주세요 label Apr 22, 2021
@dididy dididy self-assigned this Apr 22, 2021
@SeonHyungJo
Copy link
Owner

혹시 눌러서 해당 질문으로 이동이 되나요?

@dididy
Copy link
Collaborator Author

dididy commented Apr 22, 2021

혹시 눌러서 해당 질문으로 이동이 되나요?

@SeonHyungJo typora 랑 vscode extension으로 테스트시 되었는데 github md 프리뷰에서는 안되는군요.. 확인해보니 ?를 붙여서 그런 것 같습니다.

https://github.com/SeonHyungJo/reactjs-interview-questions-korean/blob/efd8315b39dd20b79a2b23c91a0b25a7c47efb7f/README.md#prop-drilling-이란-무엇인가

위 url로 변경 후 푸시 하겠습니다!

- ?를 붙이면 링크 이동이 안되는 문제 수정
@SeonHyungJo
Copy link
Owner

SeonHyungJo commented Apr 22, 2021

간단하게 물음표만 제거해도 되지않나요? @dididy

@dididy
Copy link
Collaborator Author

dididy commented Apr 22, 2021

간단하게 물음표만 제거해도 되지않나요? @dididy

@SeonHyungJo 그렇게 반영하였습니다! 550144d

Copy link
Owner

@SeonHyungJo SeonHyungJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

Copy link
Collaborator

@BKJang BKJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BKJang BKJang merged commit 09bc5f2 into master Apr 28, 2021
@BKJang BKJang deleted the transition-330 branch April 28, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝확인요청 Review 해주세요
Projects
None yet
Development

Successfully merging this pull request may close these issues.

330번 제목 추가 번역 요청
3 participants