Colorful ghosts #734
Merged
Colorful ghosts #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DexlerXD
suggested changes
Feb 14, 2024
Content.Client/Ghost/GhostSystem.cs
Outdated
Comment on lines
134
to
139
| // при прямом указаний цвета в sprite.LayerSetColor цвет назначается, если это делать через рандомизацию (даже если цвет успешно сгенерирован и это видно в дебагере)... | ||
| // ...тогда стандартный гост, увы | ||
| var _random = new Random(); | ||
| var color = new Color(_random.Next(1, 255), _random.Next(1, 255), _random.Next(1, 255)); | ||
| if (TryComp<SpriteComponent>(uid, out var sprite)) | ||
| sprite.LayerSetColor(0, component.color); | ||
| sprite.LayerSetColor(0, color); |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
@Werzet забыл наверное про беднягу |
github-actions
bot
added
Status: Needs Review
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DexlerXD
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
По просьбе адуча восстановил по памяти то, что я делал ещё перед НГ.
Если кратко о проблеме:
Когда цвет назначается напрямую в sprite.LayerSetColor(), то цвет назначается. Если это сделать через предварительно сгенерированный цвет и передать его в качестве аргумента, то получаем стандартный цвет госта по итогу.
Возможно, решается через генерацию цвета на сервере и его передачу на GhostComponent color в конструкторе
Медиа
Проверки
Изменения
🆑 Lazzi, Wer