Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use prebuilt clang binaries on windows #1477

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

alimpfard
Copy link
Member

No description provided.

@alimpfard alimpfard force-pushed the use-prebuilt-clang branch 7 times, most recently from 9ae87d1 to 9d74bf4 Compare September 2, 2023 15:08
@alimpfard alimpfard closed this Sep 2, 2023
@alimpfard alimpfard reopened this Sep 2, 2023
@alimpfard alimpfard force-pushed the use-prebuilt-clang branch 4 times, most recently from cc7d0f8 to b3fc636 Compare September 3, 2023 12:31

- name: Build Jakt Stage 1 Selfhost
run: cmake --build build

- name: Test Jakt Stage 1
run: .\build\bin\jakttest.exe
run: .\build\bin\jakttest.exe --cpp-compiler $env:CXX_COMPILER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't pass clang.exe here, there's a check that we're using clang-cl.exe :yakthonk:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or wait, that's for down below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I noticed, will check if we have clang-cl in the binaries.

@alimpfard alimpfard force-pushed the use-prebuilt-clang branch 3 times, most recently from d7acdc1 to 1cc06e2 Compare September 3, 2023 18:43
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@alimpfard alimpfard merged commit c4b268b into SerenityOS:main Sep 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants