fix(metadata): compatibility with old kv records #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix `Error 500: Cannot read properties of null` on old kv records
Misaka13514
force-pushed
the
goshujin-sama
branch
from
48a3918 to
1ede146
Compare
|
Oh, that must been some ancient pastes. I am planning to introduce metadata scheme versions for later extensions. But good to have these alleviations now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
Error 500: Cannot read properties of nullon old kv recordsMaybe not every change is needed, but i think there's no harm in changing
item.metadata -> item.metadata?uniformly?