Merge pull request GSA#7979 from GSA/nl-patch-guide-sidenav-a11y

Fix container element #3
SherfeyInv · Oct 1, 2024 · 437fde0 · 437fde0
2 parents 091382a + 071ad89
commit 437fde0
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/themes/digital.gov/src/js/guide-sidenav.js b/themes/digital.gov/src/js/guide-sidenav.js
@@ -120,15 +120,18 @@ function createSublist() {
   const subList = document.createElement("ul");
   subList.classList.add("usa-sidenav__sublist");
   const links = createLinks();
-  links.forEach((link) => {
-    const subItem = document.createElement("li");
-    subItem.classList.add("usa-sidenav__item");
-    subItem.appendChild(link);
-    subList.appendChild(subItem);
-  });
-  const currentItem = document.querySelector(".usa-sidenav__item.current");
-  if (currentItem) {
-    currentItem.appendChild(subList);
+  // check if links has items to avoid displaying an empty ul
+  if (links.length !== 0) {
+    links.forEach((link) => {
+      const subItem = document.createElement("li");
+      subItem.classList.add("usa-sidenav__item");
+      subItem.appendChild(link);
+      subList.appendChild(subItem);
+    });
+    const currentItem = document.querySelector(".usa-sidenav__item.current");
+    if (currentItem) {
+      currentItem.appendChild(subList);
+    }
   }
 }