Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ruby test suite against truffleruby in CI #204

Merged
merged 4 commits into from
Sep 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,17 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '2.7', '3.0', '3.1', '3.2' ]
ruby:
- '2.7'
- '3.0'
- '3.1'
- '3.2'
- 'truffleruby'
steps:
- uses: actions/checkout@v2
- name: Install deps
run: |
sudo apt-get install libsnappy-dev
- name: Set up Ruby ${{ matrix.ruby }}
uses: ruby/setup-ruby@v1
with:
Expand Down
1 change: 1 addition & 0 deletions .spin/packages.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- libsnappy-dev
8 changes: 8 additions & 0 deletions dev.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# This file is for Shopify employees development environment.
# If you are an external contributor you don't have to bother with it.

name: ci-queue

up:
- snappy
2 changes: 1 addition & 1 deletion ruby/test/integration/grind_redis_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_grind_command_runs_tests

def test_grind_max_time
grind_count = 1000000
timeout = RUBY_ENGINE == "truffleruby" ? 4 : 1
timeout = RUBY_ENGINE == "truffleruby" ? 10 : 1

start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
_, err = capture_subprocess_io do
Expand Down
3 changes: 2 additions & 1 deletion ruby/test/integration/minitest_redis_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,8 @@ def test_test_data_time_reporter
.sort_by { |h| "#{h[:test_id]}##{h[:test_index]}" }
.first

assert_in_delta start_time.to_i, failure[:test_start_timestamp], 5
start_delta = RUBY_ENGINE == "truffleruby" ? 15 : 5
assert_in_delta start_time.to_i, failure[:test_start_timestamp], start_delta, "start time"
assert_in_delta end_time.to_i, failure[:test_finish_timestamp], 5
assert failure[:test_finish_timestamp] > failure[:test_start_timestamp]
end
Expand Down
Loading