Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: renamed FlatList to FlashList #97

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

efstathiosntonas
Copy link
Contributor

@efstathiosntonas efstathiosntonas commented Sep 1, 2022

Just naming convention

Description

Fixes (issue #)

Test plan

Checklist

  • I have added a decision record entry, PR includes changes to monorepo setup that may require explanation

@ElviraBurchik
Copy link
Contributor

Hey @efstathiosntonas 👋

Could you please sign CLA to get your PR reviewed?

@efstathiosntonas
Copy link
Contributor Author

@ElviraBurchik I have already signed the cla, tried again now and it throws an error that I have already signed it. 🤔

@ElviraBurchik
Copy link
Contributor

It's good to go now, as soon as the commit name follows the conventional commit format 👍

@efstathiosntonas
Copy link
Contributor Author

@ElviraBurchik do you want me to push a new commit message with -amend?

@fortmarek
Copy link
Contributor

do you want me to push a new commit message with -amend?

Yeah, you'll need to update the commit message with docs: renamed FlatList to FlashList. Then the conventional commits checker will pass.

@efstathiosntonas efstathiosntonas changed the title renamed FlatList to FlashList docs: renamed FlatList to FlashList Sep 15, 2022
@efstathiosntonas
Copy link
Contributor Author

@ElviraBurchik done!

@ElviraBurchik ElviraBurchik merged commit e0482e0 into Shopify:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants