Fix edge case for lambda with no params #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
approved these changes
Oct 30, 2024
| @@ -19,3 +19,6 @@ def method_returning_lambda | |||
| -> { 123 } | |||
| end | |||
| end | |||
|
|
|||
| # Empty lambda parameters | |||
| ->() { 1 + 2 } | |||
There was a problem hiding this comment.
Interesting that there's a difference between ->() {} and -> {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #316
Motivation
We didn't have a test case for lambdas with no block parameters. Sorbet represents this case with an empty
Argsnode, so we can check whether theparametersfield inside aPM_BLOCK_PARAMETERS_NODEis anullptr, and then return early if so.Test plan
See included automated tests.