Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaulting to string type for enabled features passed to the templates #2487

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
+6 −6
Open

Defaulting to string type for enabled features passed to the templates #2487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-parents-punch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/ui-extensions': minor
---

Defaulting to string type for enabled features passed to the templates
7 changes: 1 addition & 6 deletions ...-extensions/src/surfaces/admin/api/customer-segment-template/customer-segment-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,11 @@ import type {StandardApi} from '../standard/standard';
import type {I18n} from '../../../../api';
import type {ExtensionTarget as AnyExtensionTarget} from '../../extension-targets';

/* List of enabled query language features during a progressive rollout */
type CustomerSegmentationFeature =
/* Enables templates using filters only available when B2B is enabled. For example: companies IS NOT NULL */
'b2bEnabled';

export interface CustomerSegmentTemplateApi<
ExtensionTarget extends AnyExtensionTarget,
> extends StandardApi<ExtensionTarget> {
/* Utilities for translating content according to the current `localization` of the admin. */
i18n: I18n;
/** @private */
__enabledFeatures: CustomerSegmentationFeature[];
__enabledFeatures: string[];
}
Loading