Skip to content

Commit

Permalink
fix merge
Browse files Browse the repository at this point in the history
  • Loading branch information
shanth96 committed Dec 11, 2023
1 parent 177d2e4 commit 1a31ee2
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 9 deletions.
6 changes: 1 addition & 5 deletions go/test/endtoend/reparent/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ var (
id bigint,
msg varchar(64),
primary key (id)
) Engine=InnoDB
) Engine=InnoDB
`
cell1 = "zone1"
cell2 = "zone2"
Expand Down Expand Up @@ -128,10 +128,6 @@ func setupCluster(ctx context.Context, t *testing.T, shardName string, cells []s
shard := &cluster.Shard{Name: shardName}
shard.Vttablets = tablets

disableReplicationFlag := "--disable_active_reparents"
if clusterInstance.VtTabletMajorVersion >= 15 {
disableReplicationFlag = "--disable-replication-manager"
}
clusterInstance.VtTabletExtraArgs = append(clusterInstance.VtTabletExtraArgs,
"--lock_tables_timeout", "5s",
"--track_schema_versions=true",
Expand Down
1 change: 0 additions & 1 deletion go/vt/vtgate/semantics/early_rewriter.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ package semantics
import (
"fmt"
"strconv"
"strings"

"vitess.io/vitess/go/vt/vtgate/evalengine"

Expand Down
1 change: 0 additions & 1 deletion go/vt/vttablet/tabletmanager/rpc_actions.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ limitations under the License.
package tabletmanager

import (
"errors"
"fmt"
"time"

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vttablet/tabletserver/schema/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ func NewEngineForTests() *Engine {
se := &Engine{
isOpen: true,
tables: make(map[string]*Table),
historian: newHistorian(false, nil),
historian: newHistorian(false, 0, nil),
}
return se
}
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vttablet/tabletserver/schema/engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ func TestOpenNoErrorDueToInvalidViews(t *testing.T) {
db.AddRejectedQuery("SELECT `col1`, `col2` FROM `fakesqldb`.`bar_view` WHERE 1 != 1", mysql.NewSQLError(mysql.ERWrongFieldWithGroup, mysql.SSClientError, "random error for table bar_view"))

AddFakeInnoDBReadRowsResult(db, 0)
se := newEngine(10, 1*time.Second, 1*time.Second, db)
se := newEngine(10, 1*time.Second, 1*time.Second, 0, db)
err := se.Open()
require.NoError(t, err)

Expand Down

0 comments on commit 1a31ee2

Please sign in to comment.