#552 Fixed ball spawning in minigame lobbies.

Shynixn · Sep 17, 2024 · fdd2e01 · fdd2e01
1 parent 78bbd1a
commit fdd2e01
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 8 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -9,7 +9,7 @@ plugins {
 }
 
 group = "com.github.shynixn"
-version = "7.3.0"
+version = "7.3.1"
 
 repositories {
     mavenLocal()
@@ -26,7 +26,7 @@ tasks.register("printVersion") {
 
 dependencies {
     // Compile Only
-    compileOnly("me.clip:placeholderapi:2.9.2")
+    compileOnly("me.clip:placeholderapi:2.11.6")
     compileOnly("org.spigotmc:spigot-api:1.18.2-R0.1-SNAPSHOT")
 
     // Library dependencies with legacy compatibility, we can use more up-to-date version in the plugin.yml
@@ -42,7 +42,7 @@ dependencies {
 
     // Custom dependencies
     implementation("com.github.shynixn.mcutils:common:2024.23")
-    implementation("com.github.shynixn.mcutils:packet:2024.33")
+    implementation("com.github.shynixn.mcutils:packet:2024.38")
     implementation("com.github.shynixn.mcutils:database:2024.2")
     implementation("com.github.shynixn.mcutils:sign:2024.3")
     implementation("com.github.shynixn.mcutils:guice:2024.2")

diff --git a/src/main/java/com/github/shynixn/blockball/impl/SoccerMiniGameImpl.kt b/src/main/java/com/github/shynixn/blockball/impl/SoccerMiniGameImpl.kt
@@ -156,6 +156,7 @@ class SoccerMiniGameImpl constructor(
                     playing = true
                     status = GameState.RUNNING
                     matchTimeIndex = -1
+                    ballEnabled = true
                     switchToNextMatchTime()
                 }
             }

diff --git a/src/main/java/com/github/shynixn/blockball/impl/service/DependencyPlaceHolderServiceImpl.kt b/src/main/java/com/github/shynixn/blockball/impl/service/DependencyPlaceHolderServiceImpl.kt
@@ -1,3 +1,5 @@
+@file:Suppress("UselessCallOnNotNull")
+
 package com.github.shynixn.blockball.impl.service
 
 import com.github.shynixn.blockball.contract.SoccerGame
@@ -58,8 +60,8 @@ class DependencyPlaceHolderServiceImpl @Inject constructor(
         return "blockball"
     }
 
-    override fun onPlaceholderRequest(player: Player?, params: String?): String? {
-        if (params == null) {
+    override fun onPlaceholderRequest(player: Player?, params: String): String? {
+        if (params.isNullOrBlank()) {
             return null
         }
 

diff --git a/src/main/java/com/github/shynixn/blockball/impl/service/GameServiceImpl.kt b/src/main/java/com/github/shynixn/blockball/impl/service/GameServiceImpl.kt
@@ -118,7 +118,9 @@ class GameServiceImpl @Inject constructor(
                     scoreboardService,
                     commandService,
                     soccerBallFactory
-                )
+                ).also {
+                    it.ballEnabled = false
+                }
             }
 
             games.add(game)

diff --git a/src/main/resources/plugin-legacy.yml b/src/main/resources/plugin-legacy.yml
@@ -1,5 +1,5 @@
 name: BlockBall
-version: 7.3.0
+version: 7.3.1
 author: Shynixn
 website: https://www.spigotmc.org/members/shynixn.63455/
 main: com.github.shynixn.blockball.BlockBallPlugin

diff --git a/src/main/resources/plugin.yml b/src/main/resources/plugin.yml
@@ -1,5 +1,5 @@
 name: BlockBall
-version: 7.3.0
+version: 7.3.1
 author: Shynixn
 website: https://www.spigotmc.org/members/shynixn.63455/
 main: com.github.shynixn.blockball.BlockBallPlugin