Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToT calibration script on per pixel level #33

Merged
merged 18 commits into from
Feb 20, 2024
Merged

Conversation

lschall
Copy link
Member

@lschall lschall commented May 23, 2023

This PR enables per pixel ToT calibration. A scan routine analogue to a threshold scan as basis for the calibration is added. Analyzing scripts converting a measured ToT spectrum (source/beam spectrum) w.r.t. a calibration file are added. Fixes Issue #29.

@lschall lschall added enhancement New feature or request software Related to software labels May 23, 2023
@lschall lschall self-assigned this May 23, 2023
@lschall lschall changed the title *WIP* ToT calibration skript on per pixel level ToT calibration skript on per pixel level Jun 19, 2023
@lschall lschall requested a review from cbespin June 19, 2023 13:45
@lschall lschall changed the title ToT calibration skript on per pixel level ToT calibration script on per pixel level Feb 15, 2024
Copy link
Collaborator

@cbespin cbespin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I have some minor comments, mostly just optimizations or questions that we can also discuss in person

tjmonopix2/analysis/analysis.py Show resolved Hide resolved
tjmonopix2/analysis/analysis.py Show resolved Hide resolved
tjmonopix2/analysis/analysis.py Outdated Show resolved Hide resolved
tjmonopix2/analysis/analysis.py Outdated Show resolved Hide resolved
tjmonopix2/analysis/analysis.py Outdated Show resolved Hide resolved
tjmonopix2/analysis/plotting.py Outdated Show resolved Hide resolved
tjmonopix2/analysis/plotting.py Outdated Show resolved Hide resolved
tjmonopix2/analysis/plotting.py Outdated Show resolved Hide resolved
tjmonopix2/analysis/plotting.py Outdated Show resolved Hide resolved
tjmonopix2/analysis/plotting.py Outdated Show resolved Hide resolved
@cbespin
Copy link
Collaborator

cbespin commented Feb 20, 2024

Great PR, thanks for the fixes! I will merge it as soon as the pipeline is finished!

@lschall lschall merged commit d7a35fe into development Feb 20, 2024
3 checks passed
@lschall lschall deleted the calibrate_tot branch February 20, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request software Related to software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants