-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated folder name and structure #6488
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 96f2463 in 10 seconds
More details
- Looked at
31
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.tsx:6
- Draft comment:
Ensure the import path foruseOnboardingStatus
is correct and consistent with the updated folder structure. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_OOvA3QiULai9tYmA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
Updated folder structure for useOnboardingStatus hook as one user using from open source reported that it results in the failure of his clone process.
Related Issues / PR's
#6462
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Fix folder structure by renaming
useOnboardingStatus.tsx
path and updating imports inConnectionStatus.tsx
andMessagingQueueHealthCheck.tsx
.frontend/src/hooks/messagingQueue / onboarding/useOnboardingStatus.tsx
tofrontend/src/hooks/messagingQueue/useOnboardingStatus.tsx
.ConnectionStatus.tsx
tohooks/messagingQueue/useOnboardingStatus
.MessagingQueueHealthCheck.tsx
tohooks/messagingQueue/useOnboardingStatus
.This description was created by for 96f2463. It will automatically update as commits are pushed.