Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated folder name and structure #6488

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix: updated folder name and structure #6488

merged 4 commits into from
Nov 22, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Nov 20, 2024

Summary

Updated folder structure for useOnboardingStatus hook as one user using from open source reported that it results in the failure of his clone process.

Related Issues / PR's

#6462

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Fix folder structure by renaming useOnboardingStatus.tsx path and updating imports in ConnectionStatus.tsx and MessagingQueueHealthCheck.tsx.

  • File Renames:
    • Rename frontend/src/hooks/messagingQueue / onboarding/useOnboardingStatus.tsx to frontend/src/hooks/messagingQueue/useOnboardingStatus.tsx.
  • Imports:
    • Update import path in ConnectionStatus.tsx to hooks/messagingQueue/useOnboardingStatus.
    • Update import path in MessagingQueueHealthCheck.tsx to hooks/messagingQueue/useOnboardingStatus.

This description was created by Ellipsis for 96f2463. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 96f2463 in 10 seconds

More details
  • Looked at 31 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.tsx:6
  • Draft comment:
    Ensure the import path for useOnboardingStatus is correct and consistent with the updated folder structure.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_OOvA3QiULai9tYmA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 merged commit a6968d4 into develop Nov 22, 2024
16 of 17 checks passed
@SagarRajput-7 SagarRajput-7 deleted the SIG-6462 branch November 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants