Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix genshin_merge_mods.py #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jere344
Copy link

@jere344 jere344 commented Nov 19, 2023

Fix merger for some mods like https://gamebanana.com/mods/454400

Not sure if you are interested in updating it, but the split("=", 1) especially fix a lot of mod using equal (== or !=) in the data.

Example error before fix :

Parsing ini sections
Calculating overrides and resources
Traceback (most recent call last):
  File "C:\Users\user\Desktop\genshin skin\3dmigoto-GIMI-for-playing-mods\3dmigoto\Mods\SmallKeqingMerge\original_merge_mod.py", line 396, in <module>
    main()
  File "C:\Users\user\Desktop\genshin skin\3dmigoto-GIMI-for-playing-mods\3dmigoto\Mods\SmallKeqingMerge\original_merge_mod.py", line 175, in main
    resources += f"[{all_mod_data[i]['header']}{all_mod_data[i]['name']}.{all_mod_data[i]['ini_group']}]\n"
KeyError: 'header'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant