Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IntakeGamepieces enum to IntakeGamepiece #57

Merged
merged 4 commits into from
Jan 6, 2024

Conversation

IanTapply22
Copy link
Member

Description

Renamed IntakeGamepieces enum to IntakeGamepiece to make more sense grammatically

Fixes #54

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if any
  • My changes generate no new warnings
  • I have performed tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes

@IanTapply22 IanTapply22 added the enhancement New feature or request label Dec 19, 2023
@IanTapply22 IanTapply22 self-assigned this Dec 19, 2023
Copy link

Thank you for making a pull request! Please make sure to follow the pull request guidelines for this PR. This applies to your commit messages, pull request code, and more!

@colemacphail
Copy link
Member

@IanTapply22 I think you put some stuff in this PR you didn't mean to

@IanTapply22
Copy link
Member Author

Nope, this is right. I just set the base branch to the other PR to move the intake states to separate classes so there aren't issues with the PR. Sorry for not letting you know in the description

@kaleb-dodd kaleb-dodd merged commit 56ccc2b into 2024-beta Jan 6, 2024
3 checks passed
@kaleb-dodd kaleb-dodd deleted the 54/rename-intakegamepieces-to-intakegamepiece branch January 6, 2024 01:08
@IanTapply22 IanTapply22 linked an issue Jan 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "IntakeGamepieces" enum to "IntakeGamepiece"
3 participants