Fix Sonarqube code smells and lint errors #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skShekhar
requested review from
daltonfury42,
maaverik and
mradenovic
as code owners
maaverik
requested changes
Mar 28, 2021
| @@ -1,5 +1,4 @@ | |||
| /* eslint-disable */ // TODO: Remove this | |||
| import React, { useState } from 'react'; | |||
| import React from 'react'; | |||
daltonfury42
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Thanks a lot for the PR!
Now that you have the project setup, would you like to take a stab at a feature implementation? This is a good candidate #425
maaverik
approved these changes
Mar 29, 2021
|
@daltonfury42 I can work on the max queue feature. I'm new to open source, so I wanted to know where can I post queries for any clarifications related to the feature? |
|
For any clarifications needed before you start, you can post comments on the issue thread #425. Once you have some code ready, you can raise a draft PR and we can also discuss on the PR, if needed. |
maaverik
added a commit
that referenced
this pull request
Apr 17, 2021
* Remove amplify backend (#524) * Async actions for Queue Status and My Queues API calls (#522) * Add gitter chat badge (#530) * Pick api base url from config. (#525) * Remove unused backend env amplify (#532) * Add LoadingStatus Component (#531) * Add LoadingStatus Component Upgrade storybook to 6.1.17 Fix LoadingIndicator stories * Pause resume queue (#586) * Merge fixes after pause queue (#598) * Add plus prefix to phone number, rename onClick to onSubmit (#600) * Fix Sonarqube code smells and lint errors (#599) * Fix Sonarqube code smells and lint errors * Address review comments - revert direct return and eslintrc * Some minor changes to add A2HS (#602) * Added size property to the icons & shortened name * file name changed * a square 144x144px icon of the logo * register the service worker to enable pwa * Modified phone icon on footer and ErrorHandler (#604) * Removed phone icon with outdated link * Added optional chaining in PageNotFound * Fix return home button when reaching from errorHandler * Intentional bug to check sentry logging * Customized sentry logs * Still experimenting with sentry * Trying another approach * Reverted intentional bugs and removed popup notifcation (#605) * Reverted intentional bugs and removed popup notifcation * Fix code style issues with ESLint * Make Contact Us on Navbar bit more bold to stand out (#609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the left over Sonar code smells mentioned in #548.
pathstomoduleDirectoryinimport/resolverto fix theUnable to resolve path to module xyzeslint warning