Various Fixes #7927
Merged
Various Fixes #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just some fixes found by intelisense As well, I saw we have magic quotes stuff. It looks like get_magic_quotes_gpc and various other stuff was removed in 8.0. We can safely remove this now.
jdarwood007
commented
Dec 2, 2023
| @@ -1231,8 +1231,7 @@ public static function spellCheck(): void | |||
|
|
|||
| // Free resources for enchant... | |||
| if (isset(Utils::$context['enchant_broker'])) { | |||
| enchant_broker_free_dict($dict); | |||
| enchant_broker_free(Utils::$context['enchant_broker']); | |||
| unset($dict, Utils::$context['enchant_broker']); | |||
There was a problem hiding this comment.
Note here, the enchant_*free functions are deprecated, they recommend just destroying the object.
Sesquipedalian
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some fixes found by intelisense. I worked through some stuff. Didn't get into actions.
As well, I saw we have magic quotes stuff. It looks like get_magic_quotes_gpc and various other stuff was removed in 8.0. We can safely remove this now.