fix: Move setting avatar logic before checking for hook usage #8351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a check on Profie-View when trying to build u the text for the alert:
The check is assuming that someone using the integrate_fetch_alerts already build their own text key which is OK, however, the check also prevents setting the 'sender' key with the profile data from the sender_id already loaded previously.
This forces whoever uses the integrate_fetch_alerts hook to load their own sender_id profile data which means adding extra queries for data that is already available.
This PR simply moves the code for populating 'sender' key before the check to 'text'