Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cordova androidx build [SI-869] #4

Closed
wants to merge 1 commit into from
Closed

fix: cordova androidx build [SI-869] #4

wants to merge 1 commit into from

Conversation

samvimes01
Copy link

@samvimes01 samvimes01 commented Jan 19, 2021 •
edited
Loading

to fix android.support.v7 errors on Capacitor

Should be merged after capacitor migration

Telerik-Verified-Plugins#236
ionic-team/capacitor#2289

@samvimes01 samvimes01 self-assigned this Jan 19, 2021
@quentin-tardivon
Copy link

I think I missed a step here... Why is this fix targeting master? 🤔

@samvimes01
Copy link
Author

@quentin-tardivon - this is an ImagePicker library fork. We don't need a special capacitor branch here
What branch should it be targeting?

@quentin-tardivon
Copy link

@quentin-tardivon - this is an ImagePicker library fork. We don't need a special capacitor branch here
What branch should it be targeting?

Yes sorry, I didn't paid attention to the repo 🤭

quentin-tardivon
quentin-tardivon approved these changes Jan 21, 2021
View reviewed changes
Copy link

@quentin-tardivon quentin-tardivon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ArnaudSpanneut
ArnaudSpanneut approved these changes Jan 26, 2021
View reviewed changes
Copy link

@ArnaudSpanneut ArnaudSpanneut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be safer to create versions of this repo and use them in the mobile project to avoid this kind of situation

@pintojeremy
Copy link

Since I'll add jetifier to our postinstall step, we may not need this fork anymore.

@pintojeremy
Copy link

jetifier has been added. This PR may be obsolete

@samvimes01
Copy link
Author

Closing it since we use Jetifier for File opener, but it fixes paths everywhere

@samvimes01 samvimes01 closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentin-tardivon quentin-tardivon quentin-tardivon approved these changes

@ArnaudSpanneut ArnaudSpanneut ArnaudSpanneut approved these changes

@pintojeremy pintojeremy Awaiting requested review from pintojeremy

Assignees

@samvimes01 samvimes01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samvimes01 @quentin-tardivon @pintojeremy @ArnaudSpanneut