delete duplicate for loop. #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire for loop under the comment `Once all oracles were queried, get consensus time for each feed` is duplicated. All of the effects happen in `metrics.updateConsensusTimeTaken(feed, consensusTime);`, so the duplication should be idempotent.
|
@jacquesvcritien Where should this be sent? It's very minor. |
|
Good catch, thanks! This must have been a result of some merge conflict. This script is used to monitor the oracle network. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire for loop under the comment
Once all oracles were queried, get consensus time for each feedis duplicated. All of the effects happen inmetrics.updateConsensusTimeTaken(feed, consensusTime);, so the duplication should be idempotent.