Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: Pin versions, tidy up upload-artifact calls #185

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Fix CI: Pin versions, tidy up upload-artifact calls #185

merged 5 commits into from
Oct 15, 2024

Conversation

MakisH
Copy link
Contributor

@MakisH MakisH commented Oct 15, 2024

Description

  • Pins the pandoc/latex version to 2 -> Fixes the undefined ref issue, triggered in version 3. Not sure if it is worth investing more effort here.
  • Bumps the runner version to 22.04 (could even be latest), as the 20.04 should anyway be EOL.
  • Fixes an image URL that returned 404.
  • Removes duplicate calls to upload-artifacts and names the remaining two (slides and texts)

This can be merged as-is, without squashing.

Checklist

  • I made sure that the markdown files are formatted properly. -> N/A
  • I made sure that all hyperlinks are working.
  • I added the new content to the README.md inside the topics subdirectory, e.g., 01_version_control/README.md. -> N/A
  • I added the new content to the timetable.md in the root of this repository. -> N/A

Please check that the uploaded artifacts are as intended.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@uekerman uekerman merged commit 2f8d18b into main Oct 15, 2024
4 checks passed
@uekerman uekerman deleted the fix-ci branch October 15, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants