When loading the model, delay resource configuration until after it's loaded #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when Melange was solving a cross-ref of the model, a Melange query was always added to the URI of the cross-ref although Melange needed to access to the resource without any query. This PR delays the configuration of the ResourceSet with the XMLURIHandler and the MelangeURIConverter, until after the model was entirely loaded, which includes the MelangeResource creation, and avoids the aforementioned problem.
…ay-resource-configuration
|
with the transfer of the code to the Eclipse foundation (see gemoc@eclipse), this repository is now deprecated and replaced by https://github.com/eclipse/gemoc-studio-modeldebugging/ Since only the master branch was transfered, this pull request was not taken into account. Please consider contributing/adapting this pull request to the new official repository https://github.com/eclipse/gemoc-studio-modeldebugging/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when Melange was solving a cross-ref of the model, a Melange query was always added to the URI of the cross-ref although Melange needed to access to the resource without any query.
This PR delays the configuration of the
ResourceSetwith theXMLURIHandlerand the MelangeURIConverter, until after the model was entirely loaded, which includes theMelangeResource` creation, and avoids the aforementioned problem.