Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting and react types errors for monorepo #1613

Merged
merged 5 commits into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Our versioning strategy is as follows:
* `[templates/nextjs]` Next config header plugin for CORS. ([#1597](https://github.com/Sitecore/jss/pull/1597))
* `[templates/nextjs]` Ensure dictionary data is only fetched when layout data is present for a route ([#1608](https://github.com/Sitecore/jss/pull/1608))
* `[sitecore-jss-react-forms]` Form should be blocked while submit is in progress to avoid submit spam ([#1611](https://github.com/Sitecore/jss/pull/1611))
* `[templates/nextjs]` Fix linting error ([#1613](https://github.com/Sitecore/jss/pull/1613))

### 🛠 Breaking Changes

Expand Down
3 changes: 2 additions & 1 deletion packages/create-sitecore-jss/src/templates/nextjs/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"plugins": [
"@typescript-eslint",
"prettier",
"yaml"
"yaml",
"react"
],
"ignorePatterns": [".generated/**/*", "**/*.d.ts", "**/*.js"],
"rules": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"eslint-config-next": "^13.1.5",
"eslint-config-prettier": "^8.6.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-react": "^7.32.1",
"eslint-plugin-yaml": "^0.5.0",
"graphql-let": "^0.18.6",
"npm-run-all": "~4.1.5",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"lib/*": ["src/lib/*"],
"temp/*": ["src/temp/*"],
"assets/*": ["src/assets/*"],
"graphql-types": ["node_modules/@types/graphql-let/__generated__/__types__"]
"graphql-types": ["node_modules/@types/graphql-let/__generated__/__types__"],
"react": ["node_modules/@types/react"]
},
"target": "es5",
"lib": ["dom", "dom.iterable", "esnext"],
Expand Down
2 changes: 1 addition & 1 deletion packages/sitecore-jss-nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@types/mocha": "^10.0.1",
"@types/node": "~18.11.18",
"@types/prop-types": "^15.7.5",
"@types/react": "^18.0.27",
"@types/react": "^18.2.22",
"@types/react-dom": "^18.0.10",
"@types/sinon": "^10.0.13",
"@types/sinon-chai": "^3.2.9",
Expand Down
2 changes: 1 addition & 1 deletion packages/sitecore-jss-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@types/mocha": "^10.0.1",
"@types/node": "18.11.10",
"@types/prop-types": "^15.7.5",
"@types/react": "^18.0.27",
"@types/react": "^18.2.22",
"@types/react-dom": "^18.0.10",
"@types/sinon": "^10.0.13",
"@types/sinon-chai": "^3.2.9",
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6641,7 +6641,7 @@ __metadata:
"@types/mocha": ^10.0.1
"@types/node": ~18.11.18
"@types/prop-types": ^15.7.5
"@types/react": ^18.0.27
"@types/react": ^18.2.22
"@types/react-dom": ^18.0.10
"@types/sinon": ^10.0.13
"@types/sinon-chai": ^3.2.9
Expand Down Expand Up @@ -6788,7 +6788,7 @@ __metadata:
"@types/mocha": ^10.0.1
"@types/node": 18.11.10
"@types/prop-types": ^15.7.5
"@types/react": ^18.0.27
"@types/react": ^18.2.22
"@types/react-dom": ^18.0.10
"@types/sinon": ^10.0.13
"@types/sinon-chai": ^3.2.9
Expand Down Expand Up @@ -7843,14 +7843,14 @@ __metadata:
languageName: node
linkType: hard

"@types/react@npm:^18.0.27":
version: 18.0.27
resolution: "@types/react@npm:18.0.27"
"@types/react@npm:^18.2.22":
version: 18.2.22
resolution: "@types/react@npm:18.2.22"
dependencies:
"@types/prop-types": "*"
"@types/scheduler": "*"
csstype: ^3.0.2
checksum: 600fdbc39a92ea4a77047db3e12f05f67776a710f5918248c0189a59ac2a38900c9db5a5d2e433a16df528a3ecab1aa114b322cacea573bb1ca2fc0b094c52d1
checksum: 44289523dabaadcd3fd85689abb98f9ebcc8492d7e978348d1c986138acef4801030b279e89a19e38a6319e294bcea77559e37e0c803e4bacf2b8ae3a56ba587
languageName: node
linkType: hard

Expand Down