Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs][templates/nextjs-sxa] Extend retrier to ErrorPagesService and make it configurable through env #1619

Merged
merged 5 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Our versioning strategy is as follows:
* `[sitecore-jss-dev-tools]` `[templates/nextjs]` `[templates/react]` Introduce "components" configuration for ComponentBuilder ([#1598](https://github.com/Sitecore/jss/pull/1598))
* `[sitecore-jss-react]` `[sitecore-jss-nextjs]` Component level data fetching(SSR/SSG) for BYOC ([#1610](https://github.com/Sitecore/jss/pull/1610))
* `[sitecore-jss-nextjs]` Reduce the amount of Edge API calls during fetch getStaticPaths ([#1612](https://github.com/Sitecore/jss/pull/1612))
* `[sitecore-jss]` `[templates/nextjs]` GraphQL Layout and Dictionary services can handle endpoint rate limits through retryer functionality in GraphQLClient. To prevent SSG builds from failing and enable multiple retries, set retry amount in lib/dictionary-service-factory and lib/layout-service-factory ([#1618](https://github.com/Sitecore/jss/pull/1618))
* `[sitecore-jss]` `[templates/nextjs] [templates/nextjs-sxa]` GraphQL Layout and Dictionary services in base remplate, and ErrorPages service in nextjs-sxa can handle endpoint rate limits through retryer functionality in GraphQLClient. To prevent SSG builds from failing and enable multiple retries, set retry amount in lib/dictionary-service-factory and lib/layout-service-factory ([#1618](https://github.com/Sitecore/jss/pull/1618) [#1619](https://github.com/Sitecore/jss/pull/1619))
* `[templates/nextjs]` `[sitecore-jss-nextjs]` Upgrade Nextjs to 13.4.16([#1616](https://github.com/Sitecore/jss/pull/1616))

### 🧹 Chores
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ export const getStaticProps: GetStaticProps = async (context) => {
apiKey: config.sitecoreApiKey,
siteName: site.name,
language: context.locale || config.defaultLanguage,
retries:
(process.env.GRAPH_QL_SERVICE_RETRIES &&
parseInt(process.env.GRAPH_QL_SERVICE_RETRIES, 10)) ||
0,
});
let resultErrorPages: ErrorPages | null = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ export const getStaticProps: GetStaticProps = async (context) => {
apiKey: config.sitecoreApiKey,
siteName: site.name,
language: context.locale || context.defaultLocale || config.defaultLanguage,
retries:
(process.env.GRAPH_QL_SERVICE_RETRIES &&
parseInt(process.env.GRAPH_QL_SERVICE_RETRIES, 10)) ||
0,
});
let resultErrorPages: ErrorPages | null = null;

Expand Down
3 changes: 3 additions & 0 deletions packages/create-sitecore-jss/src/templates/nextjs/.env
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ JSS_APP_NAME=
# Your default app language.
DEFAULT_LANGUAGE=

# How many times should GraphQL Layout, Dictionary and ErrorPages services retry a fetch when endpoint rate limit is reached
GRAPH_QL_SERVICE_RETRIES=0

# The way in which layout and dictionary data is fetched from Sitecore
FETCH_WITH=<%- fetchWith %>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ export class DictionaryServiceFactory {
It will only try the request once by default.
retries: 'number'
*/
retries:
(process.env.GRAPH_QL_SERVICE_RETRIES &&
parseInt(process.env.GRAPH_QL_SERVICE_RETRIES, 10)) ||
0,
})
: new RestDictionaryService({
apiHost: config.sitecoreApiHost,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ export class LayoutServiceFactory {
It will only try the request once by default.
retries: 'number'
*/
retries:
(process.env.GRAPH_QL_SERVICE_RETRIES &&
parseInt(process.env.GRAPH_QL_SERVICE_RETRIES, 10)) ||
0,
})
: new RestLayoutService({
apiHost: config.sitecoreApiHost,
Expand Down
8 changes: 5 additions & 3 deletions packages/sitecore-jss/src/site/graphql-error-pages-service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { GraphQLClient, GraphQLRequestClient } from '../graphql';
import { GraphQLClient, GraphQLRequestClient, GraphQLRequestClientConfig } from '../graphql';
import { siteNameError } from '../constants';
import debug from '../debug';
import { LayoutServiceData } from '../layout';
Expand All @@ -23,7 +23,8 @@ const defaultQuery = /* GraphQL */ `
}
`;

export type GraphQLErrorPagesServiceConfig = {
export interface GraphQLErrorPagesServiceConfig
extends Pick<GraphQLRequestClientConfig, 'retries'> {
/**
* Your Graphql endpoint
*/
Expand All @@ -40,7 +41,7 @@ export type GraphQLErrorPagesServiceConfig = {
* The language
*/
language: string;
};
}

/**
* Object model of Error Pages result
Expand Down Expand Up @@ -110,6 +111,7 @@ export class GraphQLErrorPagesService {
return new GraphQLRequestClient(this.options.endpoint, {
apiKey: this.options.apiKey,
debugger: debug.errorpages,
retries: this.options.retries,
});
}
}
30 changes: 15 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6457,7 +6457,7 @@ __metadata:
"@angular/platform-browser": ~15.2.9
"@angular/platform-browser-dynamic": ~15.2.9
"@angular/router": ~15.2.9
"@sitecore-jss/sitecore-jss": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss": 21.5.0-canary.2
"@types/jasmine": ^3.4.1
"@types/node": ^14.14.35
codelyzer: ^6.0.1
Expand Down Expand Up @@ -6488,7 +6488,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@sitecore-jss/sitecore-jss-cli@workspace:packages/sitecore-jss-cli"
dependencies:
"@sitecore-jss/sitecore-jss-dev-tools": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss-dev-tools": 21.5.0-canary.2
"@types/chai": ^4.2.4
"@types/cross-spawn": ^6.0.2
"@types/mocha": ^10.0.1
Expand Down Expand Up @@ -6520,11 +6520,11 @@ __metadata:
languageName: unknown
linkType: soft

"@sitecore-jss/sitecore-jss-dev-tools@^21.5.0-canary.2, @sitecore-jss/sitecore-jss-dev-tools@workspace:packages/sitecore-jss-dev-tools":
"@sitecore-jss/[email protected], @sitecore-jss/sitecore-jss-dev-tools@workspace:packages/sitecore-jss-dev-tools":
version: 0.0.0-use.local
resolution: "@sitecore-jss/sitecore-jss-dev-tools@workspace:packages/sitecore-jss-dev-tools"
dependencies:
"@sitecore-jss/sitecore-jss": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss": 21.5.0-canary.2
"@types/chai": ^4.3.4
"@types/chokidar": ^2.1.3
"@types/del": ^4.0.0
Expand Down Expand Up @@ -6576,11 +6576,11 @@ __metadata:
languageName: unknown
linkType: soft

"@sitecore-jss/sitecore-jss-forms@^21.5.0-canary.2, @sitecore-jss/sitecore-jss-forms@workspace:packages/sitecore-jss-forms":
"@sitecore-jss/[email protected], @sitecore-jss/sitecore-jss-forms@workspace:packages/sitecore-jss-forms":
version: 0.0.0-use.local
resolution: "@sitecore-jss/sitecore-jss-forms@workspace:packages/sitecore-jss-forms"
dependencies:
"@sitecore-jss/sitecore-jss": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss": 21.5.0-canary.2
"@types/chai": ^4.3.4
"@types/chai-string": ^1.4.2
"@types/lodash.unescape": ^4.0.7
Expand All @@ -6603,9 +6603,9 @@ __metadata:
version: 0.0.0-use.local
resolution: "@sitecore-jss/sitecore-jss-nextjs@workspace:packages/sitecore-jss-nextjs"
dependencies:
"@sitecore-jss/sitecore-jss": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss-dev-tools": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss-react": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss": 21.5.0-canary.2
"@sitecore-jss/sitecore-jss-dev-tools": 21.5.0-canary.2
"@sitecore-jss/sitecore-jss-react": 21.5.0-canary.2
"@types/chai": ^4.3.4
"@types/chai-as-promised": ^7.1.5
"@types/chai-string": ^1.4.2
Expand Down Expand Up @@ -6677,7 +6677,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@sitecore-jss/sitecore-jss-react-forms@workspace:packages/sitecore-jss-react-forms"
dependencies:
"@sitecore-jss/sitecore-jss-forms": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss-forms": 21.5.0-canary.2
"@types/chai": ^4.3.4
"@types/enzyme": ^3.10.12
"@types/mocha": ^10.0.1
Expand Down Expand Up @@ -6717,7 +6717,7 @@ __metadata:
"@babel/plugin-proposal-export-default-from": ^7.5.2
"@babel/preset-env": ^7.6.2
"@babel/preset-typescript": ^7.6.0
"@sitecore-jss/sitecore-jss": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss": 21.5.0-canary.2
"@types/jest": ^24.0.18
"@types/prop-types": ^15.7.3
"@types/react": ^16.9.5
Expand Down Expand Up @@ -6747,12 +6747,12 @@ __metadata:
languageName: unknown
linkType: soft

"@sitecore-jss/sitecore-jss-react@^21.5.0-canary.2, @sitecore-jss/sitecore-jss-react@workspace:packages/sitecore-jss-react":
"@sitecore-jss/[email protected], @sitecore-jss/sitecore-jss-react@workspace:packages/sitecore-jss-react":
version: 0.0.0-use.local
resolution: "@sitecore-jss/sitecore-jss-react@workspace:packages/sitecore-jss-react"
dependencies:
"@sitecore-feaas/clientside": ^0.3.17
"@sitecore-jss/sitecore-jss": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss": 21.5.0-canary.2
"@types/chai": ^4.3.4
"@types/chai-string": ^1.4.2
"@types/deep-equal": ^1.0.1
Expand Down Expand Up @@ -6826,7 +6826,7 @@ __metadata:
resolution: "@sitecore-jss/sitecore-jss-vue@workspace:packages/sitecore-jss-vue"
dependencies:
"@babel/core": ^7.20.12
"@sitecore-jss/sitecore-jss": ^21.5.0-canary.2
"@sitecore-jss/sitecore-jss": 21.5.0-canary.2
"@types/jest": ^29.2.6
"@types/node": ^18.11.18
"@vue/compiler-dom": ^3.2.45
Expand All @@ -6850,7 +6850,7 @@ __metadata:
languageName: unknown
linkType: soft

"@sitecore-jss/sitecore-jss@^21.5.0-canary.2, @sitecore-jss/sitecore-jss@workspace:packages/sitecore-jss":
"@sitecore-jss/[email protected], @sitecore-jss/sitecore-jss@workspace:packages/sitecore-jss":
version: 0.0.0-use.local
resolution: "@sitecore-jss/sitecore-jss@workspace:packages/sitecore-jss"
dependencies:
Expand Down