Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#599694: [sitecore-jss-nextjs] fixed redirects #1629

Merged
merged 2 commits into from
Oct 11, 2023
Merged

#599694: [sitecore-jss-nextjs] fixed redirects #1629

merged 2 commits into from
Oct 11, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Oct 11, 2023 •
edited
Loading

Description / Motivation

There was problem with middleware of redirects - it worked every other time. Fixed it.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ambrauer
ambrauer reviewed Oct 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
art-alexeyenko
art-alexeyenko approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - but please elaborate a bit more on what issue was fixed in release notes before merging

@ambrauer ambrauer merged commit 8c2109f into dev Oct 11, 2023
1 check passed
@ambrauer ambrauer deleted the bugfix/599694-redirects branch October 11, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer left review comments

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc-ruslanmatkovskyi @ambrauer @art-alexeyenko