[sitecore-jss-proxy] Setting "followRedirects" to true" breaks HEAD requests #1630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
When customers use
followRedirects: true
and try to send a HEAD request, the proxy server crashes.This PR addresses this problem. When followRedirects is enabled, http-proxy-middleware initializes a proxy request before onProxyReq is called, after it's initialized there is no way to update the method without accessing to internal properties, so we swap HEAD with GET before onProxyReq is called, and change it back in onProxyReq event in case it's accessed later.
This change shouldn't be treated as a breaking change, since Express middleware accepts an array of handlers also.
Testing Details
Types of changes