Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nextjs] Update feaas clientside and adjust types in byoc bundlers #1638

Merged
merged 5 commits into from
Oct 30, 2023
Merged

[nextjs] Update feaas clientside and adjust types in byoc bundlers #1638

merged 5 commits into from
Oct 30, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

  1. Updated sitecore-feaas dependency to latests to accomodate:
  • ContextID changes
  • New types for bundler
  1. Adjusted comments
  2. Adjusted BYOC import-export logic with @Inviz 's suggestions (ground work for AppRouter BYOC support)
  3. Also locked the dependency version in sitecore-jss-react package to avoid breaking changes breaking the package.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team October 25, 2023 16:54
ambrauer
ambrauer approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ambrauer ambrauer merged commit fe176dd into dev Oct 30, 2023
1 check passed
@ambrauer ambrauer deleted the feature/jss-528-adjust-types branch October 30, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inviz Inviz Inviz left review comments

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art-alexeyenko @Inviz @ambrauer