Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#597453: [sitecore-jss-react] fixed rendering with two and more dynamic placeholders #1641

Merged
merged 4 commits into from
Oct 27, 2023
Merged

#597453: [sitecore-jss-react] fixed rendering with two and more dynamic placeholders #1641

merged 4 commits into from
Oct 27, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Oct 26, 2023 •
edited
Loading

Description / Motivation

There was issue with dynamic placeholders when there uses two and more dynamic placeholders in one component.
Added conditional for correct working dynamic placeholders.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

illiakovalenko
illiakovalenko requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should it be a "Bug Fix" in a CHANGELOG?
  2. Does the unit test cover the problem that you described?

@sc-ruslanmatkovskyi
Copy link
Collaborator Author

  1. Should it be a "Bug Fix" in a CHANGELOG?
  2. Does the unit test cover the problem that you described?
  1. Fixed
  2. Yes, I fixed unit test because it was incorrect

illiakovalenko
illiakovalenko approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko merged commit 3fa671c into dev Oct 27, 2023
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/597453-rendering-placeholder branch October 27, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-ruslanmatkovskyi @illiakovalenko