Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Support for both 'published' and 'staged' revisions of FEAAS stylesheets/themes #1644

Merged
merged 4 commits into from
Oct 30, 2023
Merged

[sitecore-jss] Support for both 'published' and 'staged' revisions of FEAAS stylesheets/themes #1644

merged 4 commits into from
Oct 30, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 27, 2023 •
edited
Loading

Description / Motivation

Introduced support for the published and staged revisions of stylesheets/themes:

  • staged: Editing, Preview modes
  • published: Normal mode

Updated unit tests structure to be split by editing, normal modes in the right way.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [sitecore-jss] [FEAAS] Load stylesheets with correct revision staged/published [sitecore-jss] Support for the published and staged revisions of FEAAS stylesheets/themes Oct 27, 2023
@illiakovalenko illiakovalenko changed the title [sitecore-jss] Support for the published and staged revisions of FEAAS stylesheets/themes [sitecore-jss] Support for the _published_ and _staged_ revisions of FEAAS stylesheets/themes Oct 27, 2023
@illiakovalenko illiakovalenko changed the title [sitecore-jss] Support for the _published_ and _staged_ revisions of FEAAS stylesheets/themes [sitecore-jss] Support for the 'published' and 'staged' revisions of FEAAS stylesheets/themes Oct 27, 2023
@illiakovalenko illiakovalenko requested a review from a team October 27, 2023 09:49
@illiakovalenko illiakovalenko changed the title [sitecore-jss] Support for the 'published' and 'staged' revisions of FEAAS stylesheets/themes [sitecore-jss] Support for both 'published' and 'staged' revisions of FEAAS stylesheets/themes Oct 27, 2023
@illiakovalenko illiakovalenko merged commit 9247ffc into dev Oct 30, 2023
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-853 branch October 30, 2023 15:06
@ambrauer ambrauer mentioned this pull request Nov 16, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @art-alexeyenko