Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAAS] Load environment-specific FEAAS stylesheets based on Sitecore Edge Platform URL #1645

Merged
merged 5 commits into from
Oct 31, 2023
Merged

[FEAAS] Load environment-specific FEAAS stylesheets based on Sitecore Edge Platform URL #1645

merged 5 commits into from
Oct 31, 2023

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Oct 30, 2023 •
edited
Loading

Description / Motivation

Newest version of FEEAS requires stylesheets being loaded from different CDN endpoints in order to work correctly (note this is an internal Sitecore problem). This is based on the Sitecore Edge Platform URL. By default, it'll use the production URL.

This PR also moves the feaas-themes page props factory plugin from the nextjs-sxa initializer add-on to the base nextjs initializer.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team October 30, 2023 21:32
illiakovalenko
illiakovalenko requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
See some minor suggestions below

packages/sitecore-jss/src/feaas/themes.ts Outdated Show resolved Hide resolved
packages/sitecore-jss/src/feaas/themes.ts Show resolved Hide resolved
packages/sitecore-jss/src/feaas/themes.test.ts Outdated Show resolved Hide resolved
@ambrauer ambrauer merged commit 89e6594 into dev Oct 31, 2023
1 check passed
@ambrauer ambrauer deleted the feature/JSS-987-feaas-stylesheets-context branch October 31, 2023 14:23
@ambrauer ambrauer mentioned this pull request Nov 16, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambrauer @illiakovalenko