Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs][templates/nextjs] Move graphql client imports to allow usage in middleware #1648

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Oct 31, 2023

Description / Motivation

Nextjs app fails if imports from the main '@sitecore-jss/sitecore-jss-nextjs' module are used in middeware. This PR moves some of the needed imports to submodules to fix middleware-related build issues.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - build, production mode work when connected to XMC Preview

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team October 31, 2023 17:33
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏼

@art-alexeyenko art-alexeyenko merged commit bb9eb88 into dev Oct 31, 2023
1 check was pending
@art-alexeyenko art-alexeyenko deleted the bug/jss-1082-import-breaks-nextjs branch October 31, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants