Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js] Fixes (part 2) for nextjs-xmcloud Initializer Template #1658

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[Next.js] Fixes (part 2) for nextjs-xmcloud Initializer Template #1658

merged 2 commits into from
Nov 8, 2023

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Nov 8, 2023

Description / Motivation

Minor fix to prevent "Are you building for XM Cloud?" prompt if nextjs-xmcloud template was specified on CLI.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer merged commit 900ccd7 into dev Nov 8, 2023
1 check was pending
@ambrauer ambrauer deleted the fix/JSS-1117-nextjs-xmcloud-template branch November 8, 2023 22:02
art-alexeyenko pushed a commit that referenced this pull request Nov 8, 2023
@ambrauer
[Next.js] Fixes (part 2) for nextjs-xmcloud Initializer Template (#…
5b2c6d3 
…1658)

* [create-sitecore-jss] Minor fix to prevent "Are you building for XM Cloud?" prompt if nextjs-xmcloud template was specified

* update CHANGELOG

(cherry picked from commit 900ccd7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ambrauer