Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-react] Pass ComponentProps param to BYOCComponent #1688

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[sitecore-jss-react] Pass ComponentProps param to BYOCComponent #1688

merged 2 commits into from
Dec 7, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Dec 7, 2023 •
edited
Loading

Description / Motivation

  • Pass ComponentProps to BYOCComponent instead of ComponentDataOverride (used for server-side fetching)

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko merged commit 583927e into dev Dec 7, 2023
1 check was pending
@illiakovalenko illiakovalenko deleted the bugfix/byoc-component-props branch December 7, 2023 09:37
illiakovalenko added a commit that referenced this pull request Dec 7, 2023
@illiakovalenko
[sitecore-jss-react] Pass ComponentProps param to BYOCComponent (#1688)
6cc41d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illiakovalenko