Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Add page state into shared context #1703

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

Extends shared context with pageState property. This allows BYOC components and CloudSDK functionality to adjust behavior based on the current state (editing, preview, normal).

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please, take a look at one comment below, there is an improvement to be added

packages/sitecore-jss-nextjs/src/context/context.ts Outdated Show resolved Hide resolved
@art-alexeyenko art-alexeyenko merged commit 69bb6a6 into dev Jan 3, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-1242-byoc-pagestate branch January 3, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants