Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Enhance Placeholder component error handling #1744

Merged
merged 18 commits into from
Feb 21, 2024
Merged

[Angular] Enhance Placeholder component error handling #1744

merged 18 commits into from
Feb 21, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Feb 20, 2024 •
edited
Loading

Description / Motivation

Pulled changes from #1706
Additionally:

  • minor refactoring
  • refactoring for unit tests
  • extended JssModule.forChild to accept components map

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [Angular] Enhance Placeholder Guard functionality [Angular] Enhance Placeholder Guard error handling Feb 20, 2024
@illiakovalenko illiakovalenko changed the title [Angular] Enhance Placeholder Guard error handling [Angular] Enhance JssCanActiavate error handling Feb 20, 2024
@illiakovalenko illiakovalenko changed the title [Angular] Enhance JssCanActiavate error handling [Angular] Enhance Placeholder Guard functionality Feb 20, 2024
@illiakovalenko illiakovalenko changed the title [Angular] Enhance Placeholder Guard functionality [Angular] Enhance JssCanActivate functionality Feb 20, 2024
@illiakovalenko illiakovalenko changed the title [Angular] Enhance JssCanActivate functionality [Angular] Enhance JssCanActivate / Error handling functionality Feb 21, 2024
@illiakovalenko illiakovalenko changed the title [Angular] Enhance JssCanActivate / Error handling functionality [Angular] Enhance Placeholder component error handling Feb 21, 2024
@illiakovalenko illiakovalenko merged commit f015de1 into dev Feb 21, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the bugfix/JSS-1448 branch February 21, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illiakovalenko