Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular][Editing Integration] Render clientScripts / clientData #1924

Merged
merged 26 commits into from
Sep 9, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 9, 2024

Description / Motivation

Introduced a new sc-editing-scripts component to enable Metadata mode editing integration.
Renders clientScripts, clientData when rendered in Metadata edit mode, otherwise doesn't produce anything

Testing Details

  • Unit Test Added
  • Manual Test/Other - tested using sxastarter

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 9, 2024 10:46
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great, see two questions, otherwise approved.

Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏼

@illiakovalenko illiakovalenko merged commit ebab255 into dev Sep 9, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-3509 branch September 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants